[FFmpeg-devel] [PATCH] pixel aspect ratio

[VolodyA! V Anarhist]

Carl Eugen Hoyos wrote:
> VolodyA! V Anarhist <Volodya <at> WhenGendarmeSleeps.org> writes:
> 
>> The code is pretty trivial and for the most part copies what happens in 
>> opt_frame_aspect_ratio().
> 
> Just a few cosmetic comments.
> Your patch contains trailing whitespace and tabs, both cannot be committed to
> FFmpeg svn.
> The maintainer prefers
> if (A) {
>     B();
>     C();
> } else {
>     D()
> }
> (Note the additional braces..)
> tools/patcheck should have told you all this.
> It's probably not necessary to send an updated patch before you get a true
> review.
> 
> Carl Eugen

Yeah, i actually prefer that myself. I just saw it everywhere else in the code 
and followed what was there. I have added the comment in the last second and 
didn't realise that i did it with a tab rather than spaces. I honestly do not 
understand what you mean by 'trailing whitespace', i have it at the end of some 
lines?

I'll resubmit the patch when i get a code review.

             - Volodya