[FFmpeg-devel] [RFC] libavformat: URL reassembly with IPv6 addresses

[Luca Abeni]

Hi Martin,

Martin Storsj? wrote:
[...]
>> I looked at it now ;-)
>> Looks ok; I just have 2 comments (uhmm... Maybe 3 :):
>> 1) It seems to me that the authorization only makes sense when a
>>    protocol is specified... No? So, I'd put the
>> 	+    if (authorization)
>> 	+        av_strlcatf(str, size, "%s:", authorization);
>>    inside the "if (proto)"
> 
> Hmm, I don't see these fields as all that tightly coupled,

Well, my point is that a protocol is needed for exchanging usernames
and passwords... So, having authorisation entries without protocols
does not look like a good idea to me.
Anyway, this is all questionable, so this comment can be skipped ;-)

[...]
>> Moreover, I would not export this function, so I'd put the
>> prototype somewhere else than in avformat.h. And I am not
>> sure if utils.c is the right place for implementing it (maybe,
>> it can be implemented in some C file that already includes
>> network.h).
> 
> It's not publicly exported at the moment, it's within #ifdef 
> HAVE_AV_CONFIG_H in avformat.h, where a few other internal, libavformat 
> common functions are declared.

Uh... Interesting. I was under the impression that such functions should
be in internal.h... :)


			Luca