[FFmpeg-devel] [PATCH v2] Beautify build output making it easier to see compiler warnings

[Stefano Sabatini]

On date Friday 2010-03-05 16:09:25 +0200, Georgi Chorbadzhiyski encoded:
> Around 03/05/10 12:14, Stefano Sabatini scribbled:
> > Consider this approach:
> > http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/95102
> > 
> > which should issue a smaller change.
> 
> Is this better:
> 
> -   $(LD) $(FFLDFLAGS) -o $$@ $$^ -l$(FULLNAME) $(FFEXTRALIBS) $$(ELIBS)
> +   $(call build_cmd,LD,$<, $(LD) $(FFLDFLAGS) -o $$@ $$^ -l$(FULLNAME) $(FFEXTRALIBS) $$(ELIBS) )
> 
> 
> Than this:
> 
> +   @echo "  CC         $<"
>     $(CCDEP)
> -   $(CC) $(CPPFLAGS) $(CFLAGS) $(CC_DEPFLAGS) -c $(CC_O) $<
> +   $(Q)$(CC) $(CPPFLAGS) $(CFLAGS) $(CC_DEPFLAGS) -c $(CC_O) $<
> 
> Sure the first one is less lines changed but in the long term when somebody
> tries to read this $(call build_cmd) it is not going to be pleasant :)
> 
> Also the minimal attached patch (based on the mail you point me to) do not
> handle many of the build targets. When install, uninstall, strip, docs, tests,
> etc. are added there will be similar number of lines + the ugliness in
> every command. Also the "eval" approach in theory will slow down the build.

Quick reply (busy at work now): all your points are valid, just I
wanted you to have a look at that - at first glance it looked simpler
(I was almost going to post a variant of that patch), let's see what
Mans/Diego will say.

Thanks for the patch, regards.
-- 
FFmpeg = Foolish and Free MultiPurpose Excellent Game