[FFmpeg-devel] [PATCH 2/3] Create a public API for FFT family of functions

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sat, Mar 06, 2010 at 04:53:50PM +0000, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > On Sat, Mar 06, 2010 at 03:38:06AM +0000, Mans Rullgard wrote:
>> >> ---
>> >>  libavcodec/Makefile |    4 +-
>> >>  libavcodec/avfft.c  |  142 +++++++++++++++++++++++++++++++++++++++++++++++++++
>> >>  libavcodec/avfft.h  |   89 ++++++++++++++++++++++++++++++++
>> >>  libavcodec/fft.h    |   28 +++--------
>> >>  4 files changed, 240 insertions(+), 23 deletions(-)
>> > [...]
>> >> +FFTContext *av_fft_init(int nbits, int inverse)
>> >> +{
>> >> +    FFTContext *s = av_malloc(sizeof(*s));
>> >> +
>> >> +    if (s)
>> >> +        ff_fft_init(s, nbits, inverse);
>> >> +
>> >> +    return s;
>> >> +}
>> >
>> > ff_fft_init() could be changed to this API and renamed to av_
>> 
>> Many codecs have an FFTContext as part of a larger struct, so that
>> wouldn't work.  Keeping it that way is probably more efficient with
>> memory, caches etc.
>
> ok then

Committed.

-- 
M?ns Rullg?rd
mans at mansr.com