[FFmpeg-devel] [RFC] Lavfi test system

[Michael Niedermayer]

On Mon, Mar 08, 2010 at 02:36:14AM +0100, Stefano Sabatini wrote:
> On date Sunday 2010-03-07 17:44:20 +0100, Michael Niedermayer encoded:
> > On Sun, Mar 07, 2010 at 04:20:16PM +0100, Stefano Sabatini wrote:
> > > On date Sunday 2010-03-07 11:18:33 +0100, Stefano Sabatini encoded:
> > > > On date Thursday 2010-01-07 23:36:02 +0100, Stefano Sabatini encoded:
> > [...]
> > > Index: libavfilter-soc/ffmpeg/tests/lavfi-regression.sh
> > > ===================================================================
> > > --- libavfilter-soc.orig/ffmpeg/tests/lavfi-regression.sh	2010-03-07 16:15:22.000000000 +0100
> > > +++ libavfilter-soc/ffmpeg/tests/lavfi-regression.sh	2010-03-07 16:16:43.000000000 +0100
> > > @@ -20,6 +20,8 @@
> > >      vfilters=$2
> > >  
> > >      if [ -n "$test" ] ; then
> > > +        slicify_h=$(expr 8 + $(date +%N) % 24)
> > > +        vfilters=slicify=$slicify_h,$vfilters
> > >          do_video_encoding ${test_name}.nut "" "-vcodec rawvideo -vfilters $vfilters"
> > >      fi
> > >  }
> > 
> > this is a problem because its not reproduceable
> > 
> > an LCG started from a constant would be better
> 
> I believed the idea was to try different slicing at every run... what
> am I missing?

we dont want spurious unreproduceable failures
or other way around spurious unreproduceable successes in teh test wen
they should fail
it makes debuging hard ...


> 
> Regards.
> -- 
> FFmpeg = Frenzy and Fostering Miracolous Problematic Erroneous Guru

>  lavfi-regression.sh |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> b361118ffebf15ed75e0bac79f4aa27b4d20d371  randomize-lavfi-test-slice-sizes.patch
> Index: libavfilter-soc/ffmpeg/tests/lavfi-regression.sh
> ===================================================================
> --- libavfilter-soc.orig/ffmpeg/tests/lavfi-regression.sh	2010-03-07 16:17:19.000000000 +0100
> +++ libavfilter-soc/ffmpeg/tests/lavfi-regression.sh	2010-03-08 02:29:41.000000000 +0100
> @@ -14,12 +14,22 @@
>  rm -f "$logfile"
>  rm -f "$benchfile"
>  
> +get_lcg()
> +{
> +    echo "65539 * $1 % (2^31-1)" | bc

where does this generator come from?
and why dont you use the generator we use elsewhere in ffmpeg?

also what should be used as random value is the scaled down value not the
modulo something value like you do later.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100308/95ddb787/attachment.pgp>