[FFmpeg-devel] [PATCH] missing dependencies for aac sbr decoder

Måns Rullgård mans
Mon Mar 8 20:56:42 CET 2010


Alex Converse <alex.converse at gmail.com> writes:

> On Mon, Mar 8, 2010 at 5:22 AM, Georgi Chorbadzhiyski <gf at unixsol.org> wrote:
>> The following patch adds missing dependencies for aac sbr decoder.
>>
>> diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c
>> index e317a5c..fe41b54 100644
>> --- a/libavcodec/aacsbr.c
>> +++ b/libavcodec/aacsbr.c
>> @@ -30,6 +30,7 @@
>> ?#include "sbr.h"
>> ?#include "aacsbr.h"
>> ?#include "aacsbrdata.h"
>> +#include "fft.h"
>>
>> ?#include <stdint.h>
>> ?#include <float.h>
>
> We get fft.h from sbr.h. Do we have a policy on that sort of thing?

The policy is that every file, .c or .h, should include every header
it depends on directly.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list