[FFmpeg-devel] [PATCH] Move H264 dsputil functions into their own struct

[Måns Rullgård]

Pavel Pavlov <pavel at summit-tech.ca> writes:

>> >> >> Mans Rullgard <mans at mansr.com> writes:
> ...
>> 
>> > They provide implementations for some performance critical functions
>> > from mp4-part 2 and 4.
>> 
>> What do you mean by that?  MP4 is ISO 14496 part 14.  Assuming you
>> meant MPEG4, we already have NEON code for the most important
>> functions in 14496-2.  Part 4 is conformance testing so your statement
>> makes little sense in relation to that.
>
> I mixed it all up :) It should have been mpeg 4, part 2 and 10 :)

MPEG4 part 10 is H264.

>> > Other than that they provide aac and mp3 decoding functions,
>> 
> ...
>> 
>> As I said, the openmax API is unusable and the code unreadable.  Why
>> should we bother with it?
>
> There is no reason to mess with it, I was just asking if that code
> could be useful. I had impression that in h263 there are only a few
> functions implemented in arm-asm.

H.263 and MPEG4 part 2 are almost the same.  We have ARM asm for IDCT
and MC, which is where most of the time is spent.  With a typical
MPEG4 file, about 50% of the decoding time is spent in asm code, the
rest in functions which are hard to write in asm.

-- 
M?ns Rullg?rd
mans at mansr.com