[FFmpeg-devel] PATCH: add missing header inclusion to intreadwrite.h

[Måns Rullgård]

Benoit Fouet <benoit.fouet at free.fr> writes:

> On Mon, 15 Mar 2010 15:48:24 +0000 M?ns Rullg?rd wrote:
>> Benoit Fouet <benoit.fouet at free.fr> writes:
>> 
>> > Hi,
>> >
>> > intreadwrite.h needs the definition of av_alias.
>> > (found when trying to build all tools in tools/)
>> > Don't know why make checkheaders didn't find it though.
>> >
>> > Index: libavutil/intreadwrite.h
>> > ===================================================================
>> > --- libavutil/intreadwrite.h	(revision 22544)
>> > +++ libavutil/intreadwrite.h	(working copy)
>> > @@ -23,6 +23,7 @@
>> >  #include "config.h"
>> >  #include "bswap.h"
>> >  #include "common.h"
>> > +#include "internal.h"
>> 
>> common.h pulls in internal.h when HAVE_AV_CONFIG_H is defined.
>
> ok, I was confused because I saw the config.h inclusion above.
>
>> The error comes from this not being defined when building the
>> tools.  Do we want the tools to stick to public API, or should we
>> simply define this for them as well?
>> 
>
> at least probetest needs the internal stuff.
> Is it possible to have HAVE_AV_CONFIG_H defined only for it ?

Anything is possible.

-- 
M?ns Rullg?rd
mans at mansr.com