[FFmpeg-devel] [PATCH] Make Make url_seek() return ESPIPE if the seek operation is not defined

[Michael Niedermayer]

On Sun, Mar 21, 2010 at 07:38:05PM +0100, Stefano Sabatini wrote:
> On date Friday 2010-03-19 00:50:55 +0100, Stefano Sabatini encoded:
> > On date Tuesday 2010-03-16 23:55:21 +0100, Stefano Sabatini encoded:
> > > Hi, $subj.
> > > -- 
> > > FFmpeg = Fascinating Frenzy Mystic Purposeless Ecumenical Gargoyle
> > 
> > > From 29721c9bf73702a2e62697368f8dca8194508326 Mon Sep 17 00:00:00 2001
> > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > Date: Tue, 16 Mar 2010 22:48:37 +0100
> > > Subject: [PATCH 01/12] Make url_seek() return ESPIPE if the seek operation is not defined in
> > >  the protocol, rather than EPIPE.
> > > 
> > > ---
> > >  libavformat/avio.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/libavformat/avio.c b/libavformat/avio.c
> > > index af9e049..1d12436 100644
> > > --- a/libavformat/avio.c
> > > +++ b/libavformat/avio.c
> > > @@ -201,7 +201,7 @@ int64_t url_seek(URLContext *h, int64_t pos, int whence)
> > >      int64_t ret;
> > >  
> > >      if (!h->prot->url_seek)
> > > -        return AVERROR(EPIPE);
> > > +        return AVERROR(ESPIPE);
> > >      ret = h->prot->url_seek(h, pos, whence & ~AVSEEK_FORCE);
> > >      return ret;
> > >  }
> 
> Well I wasn't lucid when I wrote that, ESPIPE is meaningful only with
> PIPES, maybe AVERROR_NOTSUPP is more meaningful here.

why do you want to change every error code in lav* ?


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100321/2c7de794/attachment.pgp>