[FFmpeg-devel] [PATCH] Screen frame grabbing for Win32 platform (bump)

[Michael Niedermayer]

On Tue, Mar 23, 2010 at 11:58:26PM +0100, Christophe Gisquet wrote:
[...]
> >> + ? ?for(;;) {
> >> + ? ? ? ?curtime = av_gettime();
> >> + ? ? ? ?delay = s->time_frame * av_q2d(s->time_base) - curtime;
> >> + ? ? ? ?if (delay <= 0) {
> >> + ? ? ? ? ? ?if (delay < INT64_C(-1000000) * av_q2d(s->time_base)) {
> >> + ? ? ? ? ? ? ? ?s->time_frame += INT64_C(1000000);
> >> + ? ? ? ? ? ?}
> >> + ? ? ? ? ? ?break;
> >> + ? ? ? ?}
> >> + ? ? ? ?Sleep(delay/1000);
> >> + ? ?}
> >
> > You should also support nonblocking reads.
> 
> I agree, but:
> 1) X11 grabbing does the same, suggesting a common solution
> 2) This common solution imho should be outside the device demuxers anyway
> 3) I'm not volunteering for coding an extended solution
> 
> In my humble opinion, it could be done by something like a grabbing
> thread posting grabbed frames to an encoding thread. Maybe
> overengineering but all in all, way too complex for the scope of an
> almost deprecated grab interface.

i dont see why non blocking shouldnt be supported so please add support for
it


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/1612c648/attachment.pgp>