[FFmpeg-devel] [PATCH] Add support for digest auth in the http and rtsp protocols

[Martin Storsjö]

On Wed, 24 Mar 2010, Ronald S. Bultje wrote:

> On Wed, Mar 24, 2010 at 3:32 PM, Martin Storsj? <martin at martin.st> wrote:
> > On Wed, 24 Mar 2010, Ronald S. Bultje wrote:
> >> On Tue, Mar 23, 2010 at 12:36 PM, Martin Storsj? <martin at martin.st> wrote:
> >> > +typedef struct {
> >> > + ? ?HTTPAuthType auth_type;
> >> > + ? ?HTTPAuthType best_seen_auth_type;
> >> > +} HTTPAuthState;
> >>
> >> what's the difference between these two? Right now you're only using
> >> one of them so it might be possible to remove one of the two.
> >
> > auth_type contains the currently chosen one - when starting to parse a set
> > of http headers, best_seen_auth_type should be reset to none, so that we
> > can choose the best one of the currently proposed alternatives. We can't
> > use auth_type for this, since a successfully authenticated reply doesn't
> > caontain any new WWW-Auth headers, and thus we'd lose the previous
> > selection. And if we don't reset it to none before parsing, we wouldn't
> > pick up a case where a server later would suggest a weaker one than the
> > currently selected one.
> 
> Does that ever happen?

Don't think so, it was a purely theoretical exercise. Skipping this cleans 
things up nicely.

New series attached, hopefully taking all comments into account.

// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Split-out-http-authentication-handling-into-a-separa.patch
Type: text/x-diff
Size: 12617 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/6534c7b5/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-support-for-http-digest-authentication.patch
Type: text/x-diff
Size: 11228 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/6534c7b5/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Make-ff_rtsp_send_cmd-simply-call-ff_rtsp_send_cmd_w.patch
Type: text/x-diff
Size: 904 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/6534c7b5/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Make-the-RTSP-code-use-the-separate-http-authenticat.patch
Type: text/x-diff
Size: 7714 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/6534c7b5/attachment-0003.patch>