[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Michael Niedermayer]

On Sat, Mar 27, 2010 at 03:10:01PM +0100, Reimar D?ffinger wrote:
> On Sat, Mar 27, 2010 at 03:05:34PM +0100, Stefano Sabatini wrote:
> > On date Saturday 2010-03-27 07:39:14 +0530, Mohamed Naufal encoded:
> > > +    if (avctx->get_buffer(avctx, &s->frame) < 0) {
> > > +        av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
> > > +        return -1;
> > > +    }
> > 
> > if ((ret = avctx->get_buffer(avctx, &s->frame) < 0) {
> 
> Could we please get those assignments in ifs banned?
> In 99% of cases they only make the code harder to read
> without even the slightest advantage I can see.

i dont mind a patch to patcheck that suggests this not to be done
otherwise i agree with the others that the author/maintainer should
decide such style issues

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100327/7c85a7d0/attachment.pgp>