[FFmpeg-devel] [PATCH] audio conversion clipping/overflows

[Ronald S. Bultje]

Hi,

On Sat, Mar 27, 2010 at 12:19 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Tue, Mar 16, 2010 at 12:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Tue, Mar 16, 2010 at 11:35:27AM -0400, Ronald S. Bultje wrote:
>>> Fixed in attached. Output is same. I'm still not sure if the
>>> interleaving-loops or history-related memcpy()s can be prevented, but
>>> am open to suggestions on how to achieve the same result without
>>> memcpy()s/loops.
>>
>> AVFrame get_buffer/release_buffer like we do for video can surely prevent
>> the copies in severak ways.
>> return pointer to internal buffer or require get_buffer to allocate suffiient
>> space prior to [0]
>
> Yeah, I think this is a bad idea so (as you might've noticed from my
> patches) I'm trying to change this for the better and directly write
> into the output buffer.
>
> My only problem case right now is atrac1 and wmaprodec, which do
> in-place interleaving. I'm not qualified to improve that, someone with
> actual DSP knowledge should do that.
>
> Rest is now simpler (assuming all patches are accepted), see attached.

Ping.

(Help with improving the writing of interleaved data to the output
buffers using DSP would be appreciated, I understand if Michael wants
that fixed before accepting this patch.)

Ronald