[FFmpeg-devel] [PATCH] avcodec_copy_context()

[Ronald S. Bultje]

Hi,

On Wed, Mar 31, 2010 at 4:19 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Mar 31, 2010 at 03:53:23PM -0400, Ronald S. Bultje wrote:
>> On Wed, Mar 31, 2010 at 3:47 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Wed, Mar 31, 2010 at 11:19:18AM -0400, Ronald S. Bultje wrote:
>> >> On Wed, Mar 31, 2010 at 10:53 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> > On Wed, Mar 31, 2010 at 10:11:11AM -0400, Ronald S. Bultje wrote:
>> >> >> On Wed, Mar 31, 2010 at 9:59 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> >> >> > On Wed, Mar 31, 2010 at 6:00 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> >> >> On Tue, Mar 30, 2010 at 02:23:03PM -0400, Ronald S. Bultje wrote:
>> >> >> >>> + * @param dest target codec context, should be allocated with
>> >> >> >>> + * ? ? ? ? ? ? #avcodec_alloc_context(), but otherwise uninitialized
>> >> >> >>
>> >> >> >> this should be checked if(->codec) or so maybe
>> >> >> >
>> >> >> > Coding error, so should be assert(), will add.
>> >> >
>> >> > avcodec* is public api and public api should not call abort() for invalid
>> >> > user arguments imho
>> >>
>> >> You're right, now that I think about it. AVERROR(EFAULT) OK then?
>> >
>> > EINVAL id say
>>
>> New patch attached.
>>
>> Ronald
>
>> ?avcodec.h | ? 13 +++++++++++++
>> ?options.c | ? 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> ?2 files changed, 73 insertions(+)
>> 2d67df78ac9cdda932ab19b7c0c13979dc9e8f97 ?avcodec_copy_context.patch
>
> looks ok

Applied.

Ronald