[FFmpeg-devel] [PATCH] libavdevice: v4l2: use libv4l2 when requested.

[Måns Rullgård]

Luca Abeni <lucabe72 at email.it> writes:

> On 13/05/10 22:25, M?ns Rullg?rd wrote:
>>  What's more, it does this by means of a shoddy external library.
>
> But support for this library is optional, so I do not see a big problem here

It's a bad library.  Doing it right can't be hard.

>> Worse still, the patch is a hack.
>
> I am not convinced about this (I am not talking about the configure
> part). The v4l2.c part of the patch is small, unintrusive, and it
> cannot (IMHO) create problems. And it solves a big problems for some
> people. (again, I know that performing the conversion here is not a
> good idea, but this - libv4l - is what we have right now, with almost
> 0 effort. The correct solution can be implemented later, but in the
> meanwhile people will have something working...)

If we add this, we'll never get rid of it.

>>> I agree that the correct solution would be to add support for bayer
>>> (or whatever it is) in libswscale or libavcodec, and if/when I get a
>>> webcam which requires it I'll implement the right thing.
>>
>> Wouldn't a sample capture be enough?  Or did you mean you'll implement
>> when you need it yourself?
>
> The second one :)

Oh, damn.

-- 
M?ns Rullg?rd
mans at mansr.com