[FFmpeg-devel] [PATCH] Seeking to beginning of avi file skips first audio packet

[John Stebbins]

On 05/17/2010 06:23 AM, Michael Niedermayer wrote:
> I missed the thing with the else, thanks for pointing that out. But I
>> don't understand your comment about cosmetic changes.  I only indented
>> where it was needed because of the added conditional.  The alternative
>> would be to have that chunk of code improperly indented after applying
>> the patch where it was properly indented before applying the patch.
>>
>> Here's a fix for the else.
>>
>>     
> [...]
>   
>> -            while(index>0 && st2->index_entries[index].pos > pos)
>> -                index--;
>> -            while(index+1 < st2->nb_index_entries && st2->index_entries[index].pos < pos)
>> -                index++;
>>     
> [...]
>   
>> +                while(index>0 && st2->index_entries[index].pos > pos)
>> +                    index--;
>> +                while(index+1 < st2->nb_index_entries && st2->index_entries[index].pos < pos)
>> +                    index++;
>>     
> this is a cosmetic change and requires to be in a patch without
> functional changes
>
>
> [...]
>   
>   
What am I missing here?  As I said above, if I submitted a patch without
this indentation change, then the patched code would have improper
indentation, while the unpatched code was indented correctly.  Is this
really what you want.  I just don't understand the logic. Please help me
understand this.