[FFmpeg-devel] MPEG TS encoding problem on change from stereo to mono, pay for fix

[Reimar Döffinger]

On Mon, Nov 22, 2010 at 10:27:37AM +0100, Stefano Sabatini wrote:
> -    if (ost->audio_resample && !ost->resample) {
> +    resample_changed = ost->resample_sample_fmt  != dec->sample_fmt ||
> +                       ost->resample_channels    != dec->channels   ||
> +                       ost->resample_sample_rate != dec->sample_rate;
> +
> +    if (ost->audio_resample && !ost->resample || resample_changed) {

Doesn't gcc complain with a warning that it wants some extra () here?
Also I think this is not quire right, at the very least you'll keep
a resampling context around even if input and output are the same now
if they weren't before. I'm not sure if it will actually be used, but
I think it will, too.