[FFmpeg-devel] [PATCH] mov auto crop

[Stefano Sabatini]

On date Saturday 2010-10-02 14:57:43 +0200, Benjamin Larsson encoded:
> On 10/02/2010 04:51 AM, Baptiste Coudurier wrote:
> > Hi guys,
> > 
> > $subject.
> > 
> > Please keep in mind that this issue has been present for _years_ and
> > nobody dared to fix it. I believe the patch is not so hackish/ugly.
> > 
> > I restrict it to codecs not supporting arbitrary resolutions that can be
> > stored in .mov by quicktime.
> > 
> > Maybe exporting to "crop", "wxh" is better, I don't know.
> > 
> > I plan to add auto-rotate for iphone 3gs files this way as well :)
> > 
> 
> Jolly good. But would it be possible to move this code to the api and
> just not in the ffmpeg commandline tool? Ie so the users of the api also
> would get these fixes. Other then that I like the idea.

An idea could be to provide a callback to the MOV format context,
which could be initialized by the application and which would instruct
the application about what to do when such cropping/rotation
operations are required. But I agree that this looks more bloated and
provides little gain. But maybe we should at least do a check, and
enable the cropping only if the format is MOV.

Regards.
-- 
FFmpeg = Fiendish Fantastic Maxi Philosofic Ecumenical Guide