[FFmpeg-devel] [PATCH] Broken metadata conversion for ogg

[Aurelien Jacobs]

On Tue, Sep 28, 2010 at 10:22:21PM +0100, Patrice Bensoussan wrote:
> Hi,
> 
> It seems that the metadata conversion for ogg files has been broken recently. It seems to be caused by a change in oggparsevorbis.c when calling av_metadata_set2(). The patch below to revert the change seems to be fixing the issue, but not sure it's the right way to fix the problem... I assume m variable should be pointing to metadata too?

It is definitely not the correct way to fix the problem (if there is a
problem at all!).

Right now, most calls to ff_vorbis_comment() looks like this:
  ff_vorbis_comment (s, &st->metadata, ...);
which will store metadata into the AVStream.metadata.

It looks like what you want is to store the metadata in
AVFormatContext.metadata which should be done like this:
  ff_vorbis_comment (s, &s->metadata, ...);

I'm not sure which one is the most correct, but I guess that storing
vorbis metadata in the AVStream was done on purpose.

Aurel