[FFmpeg-devel] [PATCH] Add a RTP depacketizer for the X-Qt format

[Ronald S. Bultje]

Hi,

On Sun, Oct 3, 2010 at 11:45 AM, Martin Storsj? <martin at martin.st> wrote:
> This is the first brushed up version of the depacketizer for the X-Qt
> format (i.e., any quicktime supported format, in RTP), based on earlier
> work by Ronald.
[..]
> +        if (qt->pkt.size > 0 && qt->timestamp == *timestamp) {
> +void* ptr = qt->pkt.data;
> +            qt->pkt.data = av_realloc(qt->pkt.data, qt->pkt.size + alen + FF_INPUT_BUFFER_PADDING_SIZE);
> +        } else {

What is the void ptr doing there?

I think the code needs some length-checks, there's some possible
buffer overreads (and possible overwrites as a result of that in the
memcpy()s).

Ronald