[FFmpeg-devel] [PATCH] udp: Define _DARWIN_C_SOURCE
Martin Storsjö
martin
Wed Oct 6 18:44:51 CEST 2010
On Wed, 6 Oct 2010, Igor 'Lo' (?.L.) wrote:
> >> check_type ... -D_DARWIN_C_SOURCE
> >
> > Oh, neat, thanks!
> >
> > The attached patch makes configure find this struct on OS X, and still
> > confining the define to the actual source files that need it.
> >
> > // Martin
>
> Hmm. Shouldn't be BSD test added into configure too?
>
> On FreeBSD 8.0, netinet/in.h contains an
> #if __BSD_VISIBLE
> ...
> #define IPPROTO_IPV6
> ...
> #endif
>
> structure. There was a udp.c patch suggested not so long ago, but it
> seems to be rejected. If #define __BSD_VISIBLE is put into udp.c, it
> compiles.
With the change we committed, the code should compile without problems,
right? At least you (or someone) said so in that thread. That's the first
priority, getting it to compile without errors.
The second priority is to get as much functionality enabled as possible on
each platform, and for that, a patch that adds __BSD_VISIBLE to udp.c (and
potentially to configure, if it's needed there, too) perhaps should be
considered.
// Martin
More information about the ffmpeg-devel
mailing list