[FFmpeg-devel] [PATCH/RFC] sdp/udp: Refactoring of code, don't require a ?multicast option

[Martin Storsjö]

On Thu, 7 Oct 2010, Luca Abeni wrote:

> On 10/05/2010 03:37 PM, Martin Storsj? wrote:
> [...]
> > And a question more precisely to Luca A: The solution in patch #3 isn't
> > all that pretty, but to be able to make it prettier, sdp_get_address and
> > resolve_destination would have to be merged. Would you be ok with that?
> 
> After thinking a little bit about it, my preference would be to
> have resolve_destination() returning an is_multicast value, and to do
> 	if (!is_multicast) {
> 	  ttl = 0;
> 	}
> after calling it. Then, the change to sdp_get_address() looks ok
> (or, you can remove the "else *ttl=5" if you like).

So, like this then? Ok to apply this?

// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Move-multicast-detection-fallback-code-to-network.h.patch
Type: text/x-diff
Size: 1401 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101007/b17e76fa/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Share-the-is_multicast_address-function.patch
Type: text/x-diff
Size: 2087 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101007/b17e76fa/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-sdp-Don-t-require-the-explicit-multicast-option.patch
Type: text/x-diff
Size: 3883 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101007/b17e76fa/attachment-0002.patch>