[FFmpeg-devel] [PATCH] Transpose filter

[Michael Niedermayer]

On Sun, Oct 17, 2010 at 09:54:53PM +0200, Stefano Sabatini wrote:
> On date Sunday 2010-10-17 21:16:37 +0200, Michael Niedermayer encoded:
> > On Sun, Oct 17, 2010 at 01:22:26PM +0200, Stefano Sabatini wrote:
> [...]
> > > + at section transpose
> > > +
> > > +Transpose rows with columns in the input video and optionally flip it.
> > > +
> > > +It accepts a parameter representing an integer, which can assume the
> > > +values:
> > > +
> > > +0    Rotate by 90 degrees clockwise and flip (default).
> > > +
> > > +1    Rotate by 90 degrees clockwise.
> > > +
> > > +2    Rotate by 90 degrees counterclockwise.
> > > +
> > > +3    Rotate by 90 degrees counterclockwise and flip.
> > 
> > that description is ambigous and also not very clear. flip can be horizontally
> > vertically or diaginally.
> > maybe you should write examples like
> > 1.2      4.2
> > . .  ->  . .
> > 3.4      3.1
> 
> Updated with fancy ascii art added.
> -- 
> FFmpeg = Furious Fast Mystic Patchable Eretic Gangster

>  doc/filters.texi           |   35 +++++++
>  libavfilter/Makefile       |    1 
>  libavfilter/allfilters.c   |    1 
>  libavfilter/vf_transpose.c |  211 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 248 insertions(+)
> 19f52fa952acc7efca50ef7fbc1f3742f3b566eb  0002-Add-transpose-filter.patch
> From e04cbff39214bfc1a1641b592e1af51e3111c268 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Mon, 11 Oct 2010 14:16:35 +0200
> Subject: [PATCH 2/4] Add transpose filter.

should be ok if tested and benchmarked against mplayers rotate

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101017/14f38ed7/attachment.pgp>