[FFmpeg-devel] [PATCH] libvpx: add token_partitions option

[Michael Niedermayer]

On Tue, Oct 19, 2010 at 05:54:21PM -0700, James Zern wrote:
> On Sun, Oct 17, 2010 at 15:01, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Oct 12, 2010 at 02:28:22PM -0700, Jason Garrett-Glaser wrote:
> >> On Tue, Oct 12, 2010 at 2:21 PM, James Zern <jzern at google.com> wrote:
> >> > Sorry for the delay in response to the ping on '[PATCH] libvpx:
> >> > deadline & profile support', I've been offline a bit and am just
> >> > coming back up to speed.
> >> > The attached adds a codec-specific option for libvpxenc to enable
> >> > setting the number of token partitions.
> >> > This does inherit a warning in the copy over from libvorbis for the
> >> > priv_class initialization. Should the AVCodec definition change or is
> >> > this acceptable?
> >>
> >> This seems like it should be a more generic option called --slices,
> >> which should be mapped to x264's slices option as well.
> >
> > that also could be usefull to ffv1
> >
> Attached is a pass at this. It's split between the option addition,
> libvpxenc and libx264. I wasn't sure about ffv1 given the version and
> [hv]_slices differences otherwise I would have attached one for that
> as well.
> For the new member I was thinking slice_count, but noticed that was
> already taken. As far as I could tell only the real video codecs are
> using that, but didn't think it should be reused if it serves a
> different purpose. The default of 0 should avoid changing the default
> behavior of libvpx and x264.

>  avcodec.h |   11 ++++++++++-
>  options.c |    1 +
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 075d36dd8aa59b5ede323546fe4f3a71596cb9e7  01_avcodec-add_slices_option.diff

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101022/331e70f1/attachment.pgp>