[FFmpeg-devel] [PATCH] Use MKTAG() in opt_codec_tag().

[Stefano Sabatini]

On date Sunday 2010-10-31 21:55:32 +0100, Michael Niedermayer encoded:
> On Sun, Oct 31, 2010 at 05:08:56PM +0100, Stefano Sabatini wrote:
> > On date Sunday 2010-10-31 11:32:46 +0100, Michael Niedermayer encoded:
> > > On Sat, Oct 30, 2010 at 10:12:11PM +0200, Stefano Sabatini wrote:
> > > > On date Thursday 2010-10-28 16:23:47 -0700, Stefano Sabatini encoded:
> > > > > ---
> > > > >  ffmpeg.c |    2 +-
> > > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > > > 
> > > > > diff --git a/ffmpeg.c b/ffmpeg.c
> > > > > index 3c92a26..bcda28a 100644
> > > > > --- a/ffmpeg.c
> > > > > +++ b/ffmpeg.c
> > > > > @@ -2840,7 +2840,7 @@ static void opt_codec_tag(const char *opt, const char *arg)
> > > > >  
> > > > >      *codec_tag = strtol(arg, &tail, 0);
> > > > >      if (!tail || *tail)
> > > > > -        *codec_tag = arg[0] + (arg[1]<<8) + (arg[2]<<16) + (arg[3]<<24);
> > > > > +        *codec_tag = MKTAG(arg[0], arg[1], arg[2], arg[3]);
> > > > >  }
> > > > 
> > > > Ping. I'll apply tomorrow if no one complains.
> > > 
> > > AV_RL32()
> > 
> > is pointless in this case
> 
> MKTAG(arg[0], arg[1], arg[2], arg[3]);
> vs.
> AV_RL32(arg)
> 
> later is cleaner and simpler

OK, applied the latter.
-- 
FFmpeg = Funny and Fast Muttering Powerful Elaborated Goblin