[FFmpeg-devel] [PATCH 1/2] Rename FF_MM_ symbols related to MultiMedia CPU features as AV_CPU_MM_ symbols, as they are public, and move them from libavcodec/avcodec.h to libavutil/cpu.h.

[Stefano Sabatini]

On date Thursday 2010-09-02 17:41:33 +0200, Stefano Sabatini encoded:
> On date Thursday 2010-09-02 13:44:21 +0200, Michael Niedermayer encoded:
> > On Mon, Aug 30, 2010 at 11:17:49AM +0200, Stefano Sabatini wrote:
> > > On date Monday 2010-08-30 10:54:39 +0200, Stefano Sabatini encoded:
> > > > On date Monday 2010-08-30 03:17:46 +0200, Luca Barbato encoded:
> > > > > On 08/30/2010 01:27 AM, Stefano Sabatini wrote:
> > > > > > On date Sunday 2010-08-29 23:59:35 +0100, M?ns Rullg?rd encoded:
> > > > > >> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > > > > > [...]
> > > > > >>> --- a/libavcodec/arm/dsputil_init_arm.c
> > > > > >>> +++ b/libavcodec/arm/dsputil_init_arm.c
> > > > > >>> @@ -75,7 +75,7 @@ static void simple_idct_arm_add(uint8_t *dest, int line_size, DCTELEM *block)
> > > > > >>>
> > > > > >>>  int mm_support(void)
> > > > > >>>  {
> > > > > >>> -    return HAVE_IWMMXT * FF_MM_IWMMXT;
> > > > > >>> +    return HAVE_IWMMXT * AV_CPU_MM_IWMMXT;
> > > > > >>>  }
> > > > > >>
> > > > > >> Is the MM part really needed?
> > > > > > 
> > > > > > Are not those flags related to MultiMedia extensions?
> > > > > 
> > > > > Most if not all are just simd instructions set that happen to be handy
> > > > > when doing multimedia, I'd drop that MM.
> > > > 
> > > > Updated.
> [...]
> > > Subject: [PATCH 1/2] Rename FF_MM_ symbols related to MultiMedia CPU features as AV_CPU_
> > >  symbols, and move them from libavcodec/avcodec.h to libavutil/cpu.h.
> > 
> > looks ok if tested
> 
> Other variants:
> AV_CPU_FLAG_
> AVCPU_FLAG_
> 
> in the codebase we have examples for both styles, which is the
> preferred? I tend to prefer AV_CPU_FLAG_, even if it's a bit long.

I'll apply in few days this variant if no one is against.

Regards.
-- 
FFmpeg = Foolish & Fostering Monstrous Portentous Elitarian Geisha