[FFmpeg-devel] [PATCH] nasm support

[Reimar Döffinger]

On Fri, Sep 03, 2010 at 06:21:11PM +0100, M?ns Rullg?rd wrote:
> > @@ -2569,8 +2570,21 @@
> >          elf) enabled debug && append YASMFLAGS "-g dwarf2" ;;
> >      esac
> >      if ! disabled yasm; then
> > -        check_yasm "pabsw xmm0, xmm0" && enable yasm ||
> > -            warn "yasm not found, performance will suffer"
> > +        check_yasm "pabsw xmm0, xmm0" && enable yasm
> > +        if ! enabled yasm ; then
> > +            yasmexe="nasm"
> > +            if enabled x86_64 ; then
> > +                case "$objformat" in
> > +                    elf)   objformat=elf64 ;;
> > +                    win32) objformat=win64 ;;
> > +                esac
> > +            fi
> > +            YASMFLAGS="-f $objformat -DARCH_$(toupper $subarch)"
> > +            enabled     pic           && append YASMFLAGS "-DPIC"
> > +            test -n "$extern_prefix"  && append YASMFLAGS "-DPREFIX"
> > +            check_yasm "pabsw xmm0, xmm0" && enable yasm ||
> > +                warn "yasm/nasm not found, performance will suffer"
> > +        fi
> >      fi
> 
> This diff is not against current svn

Updated version was sent shortly after.

> and such duplication is not acceptable.

I know, I was hoping for you or someone else to come up with
a nice way.
I only manage to come up with something like attached.
Btw. am I missing something or are we quite pointlessly
constructing YASMFLAGS even when yasm is disabled?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nasm.diff
Type: text/x-diff
Size: 10393 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100903/5528b153/attachment.diff>