[FFmpeg-devel] safety checks in get_*bits

[Michael Niedermayer]

On Tue, Sep 07, 2010 at 10:09:02AM +0200, Benjamin Larsson wrote:
> On 09/07/2010 09:12 AM, S?bastien Escudier wrote:
> > Hi,
> >
> > I encountered a lot of crash in ffmpeg, with corrupted streams.
> > I was wondering if there is a reason for not checking that we don't go beyond
> > buffer limits in get_*bits functions (libavcodec/get_bits.h), or before we call
> > them.
> >
> > Best regards,
> >
> > Sebastien.
> >   
> 
> Performance reasons.

yes, we though could add optional checks that are disabled by default
if someone sends a clean patch ...


    
[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100907/5c9101e3/attachment.pgp>