[FFmpeg-devel] [POF] libopencv smooth filter

[Michael Niedermayer]

On Fri, Sep 10, 2010 at 06:47:36PM +0200, Stefano Sabatini wrote:
> On date Friday 2010-09-10 12:13:05 +0200, Michael Niedermayer encoded:
> > On Fri, Sep 10, 2010 at 11:46:39AM +0200, Stefano Sabatini wrote:
> > > On date Tuesday 2010-09-07 19:52:00 +0200, Michael Niedermayer encoded:
> > > > > > its a bit ugly, to implement such wraper for each filter
> > > > > 
> > > > > What do you exactly mean? For opencv there is no way to implement a
> > > > > general wrapper (as opposed to frei0r) because for filtering we have
> > > > > to use each time a different function with a different interface.
> > > > 
> > > > so each function need to be wraped in a generic interface, it seems you do
> > > > more than that.
> > > 
> > > I can't understand yet. Note that my plan was to share different
> > 
> > you add code that is shareable in each filter wraper. 
> > 
> > > opencv filters in the same file, so at least the
> > 
> > thats good but you try to implement each of these as a independant and
> > seperate avfilter (more or less at least) and this is bad.
> > each filter should only have enough code in its wraper to get them all
> > onto a common interface and this common interface could be handled by a
> > single avfilter.
> 
> That's the point, I'm not sure that we can abstract so much the opencv
> API, since each filtering function is implemented through a different
> functions, supports a different set of colorspaces and has different
> constraints on the input arguments.
> 
> > I think thats simpler once a few filters are there.
> 
> So I suggest to apply this, when we'll have the next opencv filter
> reviewed we can consider if such a generalization is feasible.

fine, lets try that

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100911/495445a9/attachment.pgp>