[FFmpeg-devel] [PATCH] float values for libmp3lame quality

[Diego Biurrun]

On Tue, Sep 14, 2010 at 11:27:31PM +0200, James Darnley wrote:
> 2010/9/14 M?ns Rullg?rd <mans at mansr.com>:
> > James Darnley <james.darnley at gmail.com> writes:
> >> New patch with the scaling removed
> >>
> >> From 0e130a14baa9f65eba4cd2151e5cbf1785c936ec Mon Sep 17 00:00:00 2001
> >>
> >> --- a/configure
> >> +++ b/configure
> >> @@ -2709,7 +2709,12 @@ enabled libdirac ? && add_cflags $(pkg-config --cflags dirac) &&
> >> -enabled libmp3lame && require ?libmp3lame lame/lame.h lame_init -lmp3lame
> >> +enabled libmp3lame && { check_lib lame/lame.h lame_get_VBR_quality -lmp3lame &&
> >> + ? ? ? ? ? ? ? ? ? ? ? ?check_lib lame/lame.h hip_decode_init -lmp3lame ||
> >> + ? ? ? ? ? ? ? ? ? ? ? ?die "ERROR: libmp3lame version must be >= 3.98.3"; }
> >> +# check for both functions to make sure it has the required feature but is newer
> >> +# than the fix to a bug in 3.98 through 3.98.2
> >
> > Please explain.
> 
> I refer to the bug/issue that causes the error on
> libavcodec/libmp3lame.c:181 "lame: output buffer too small (buffer
> index: %d, free bytes: %d)"
> 
> I forget what the real problem is but lame say they've solve it on
> their end with 3.98.3.  Their changelog has this message: "Workaround
> for FFMPEG bug, which uses to call lame_encode_flush more than once in
> a loop"
> 
> People in #ffmpeg on IRC used to have to tell people to stop using
> 3.98 through 3.98.2.  I haven't seen this in a while so it looks as
> though most have updated.

And what happened with 3.98.3?  Sourceforge only has 3.98.2 and 3.98.4:

http://sourceforge.net/projects/lame/files/lame/

Diego