[FFmpeg-devel] [Patch] MMSH handle get_chunk_header erroringet_http_header_data

[Stephen D'Angelo]

Ah yes, sorry about that. I guess it's good practice to actually compile after refactoring a patch... I'll blame it on it being Friday evening ;)

 - Steve

> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu 
> [mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of 
> Ronald S. Bultje
> Sent: Friday, September 17, 2010 5:03 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [Patch] MMSH handle 
> get_chunk_header erroringet_http_header_data
> 
> Hi,
> 
> On Fri, Sep 17, 2010 at 4:05 PM, Stephen D'Angelo 
> <SDAngelo at evertz.com> wrote:
> > Sorry, the above patch contained extra stuff in it. ?Here is the 
> > correct patch.
> [..]
> > +        res = get_chunk_header(mmsh, &len);
> > +        if (res < 0) {
> > +            return;
> > +        }
> > +        chunk_type = res;
> 
> + res = chunk_type = ..;
> + if (res < 0) {
> +     return res; <- not return;!
> + }
> 
> Is one line less, and actually returns the error code.
> 
> Ronald
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>