[FFmpeg-devel] [PATCH 2/3] Move log_callback_help to cmdutils.[hc], for allowing sharing.

[Michael Niedermayer]

On Mon, Sep 20, 2010 at 09:12:45PM +0200, Stefano Sabatini wrote:
> ---
>  cmdutils.c |    5 +++++
>  cmdutils.h |    6 ++++++
>  ffmpeg.c   |    9 ---------
>  3 files changed, 11 insertions(+), 9 deletions(-)

[...]
> --- a/cmdutils.h
> +++ b/cmdutils.h
> @@ -45,6 +45,12 @@ extern AVFormatContext *avformat_opts;
>  extern struct SwsContext *sws_opts;
>  
>  /**
> + * Trivial log callback.
> + * Only suitable for show_help and similar since it lacks prefix handling.
> + */
> +void log_callback_help(void* ptr, int level, const char* fmt, va_list vl);

patch ok but this dox should be improved it says nothing of any use.
One doesnt even know how this functions differs from the default callback if
at all

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100920/7291badb/attachment.pgp>