[FFmpeg-devel] [PATCH2/3] asfdec.c doesn't detectaspectratioproperly in some case

[Richard Buteau]

> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> bounces at mplayerhq.hu] On Behalf Of Carl Eugen Hoyos
> Sent: Wednesday, September 22, 2010 10:10 AM
> To: ffmpeg-devel at mplayerhq.hu
> Subject: Re: [FFmpeg-devel] [PATCH2/3] asfdec.c doesn't
> detectaspectratioproperly in some case
> 
> Richard Buteau <rbuteau <at> rgbnetworks.com> writes:
> 
> [...]
> 
> > +    AVRational dar_ech;
> >      uint32_t bitrate[128];
> >
> >      memset(dar, 0, sizeof(dar));
> > +    dar_ech.den=0;
> > +    dar_ech.num=0;
done
> 
> I think you can merge declaration and initialisation here.
> 
> [...]
> 
> > -                    get_tag(s, name, value_type, value_len);
> 
> > +                        get_tag(s, name, value_type, value_len);
> 
> While it's only one line, I still believe the patch is more readable
if
> you do
> not re-indent it.
done
> 
> Carl Eugen
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: asfAR.patch_updatedv3.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100922/fd047a17/attachment.txt>