[FFmpeg-devel] [PATCH] Add asrc_anullsrc - null audio source

[Michael Niedermayer]

On Fri, Sep 24, 2010 at 10:51:51PM +0200, Stefano Sabatini wrote:
> On date Friday 2010-09-24 22:38:17 +0200, Michael Niedermayer encoded:
> > On Fri, Sep 24, 2010 at 10:13:00PM +0200, Stefano Sabatini wrote:
> > > On date Friday 2010-09-24 20:53:10 +0200, Stefano Sabatini encoded:
> > > > On date Wednesday 2010-09-15 19:42:26 +0200, Michael Niedermayer encoded:
> > > > > On Wed, Sep 15, 2010 at 04:39:47PM +0200, Stefano Sabatini wrote:
> > > > > > On date Wednesday 2010-09-15 13:54:14 +0200, Michael Niedermayer encoded:
> > > > > > > On Wed, Sep 15, 2010 at 12:56:38AM +0200, Stefano Sabatini wrote:
> > > > > > [...] 
> > > > > > > as said, the filter must be functional to be approved.
> > > > > > > source implicates that it produces some samples, a filter never returning a
> > > > > > > single sample is just broken.
> > > > > > > and you dont need a mixer (whatever that may be) to return an array inited
> > > > > > > with memset(0)
> > > > > > 
> > > > > > Repeating the same considerations I already did, why would a nullsrc
> > > > > > filter useful?
> > > > > 
> > > > > iam not asking why the filter is usefull, i know that.
> > > > > What this discussion is about is why it does not return any samples
> > > > > returning some does not hinder any of what it is usefull for but it makes
> > > > > it usefull for more things.
> > > > 
> > > > It doesn't return samples because it is supposed to the exact cousin
> > > > of the video null src, which doesn't return video frames, if you want
> > > > actual audio data you really want a different source.
> > 
> > and what about making the null video filter return black frames?
> > 
> > am i missing something, it seems a few lines of code only?
> 
> My problem with audio filtering is that I'm not currently able to test
> it, I wanted to start committing the null* stuff to start to debug and
> test filtering setup (and fix/extend the lavfi tools to work with
> audio).
> 
> That's why I'd prefer to delay this further change.

ok that makes sense now, so ok

but that also shows that ability to test is something that we need better
sooner than later

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100924/ef9c90f7/attachment.pgp>