[FFmpeg-devel] [PATCH] move set_context_opts call for video encoders to fix ... (was: Re: strict experimental)

[Janne Grunau]

On Sun, Sep 26, 2010 at 02:37:44AM +0200, Michael Niedermayer wrote:
> On Sat, Sep 25, 2010 at 12:33:34PM +0200, Janne Grunau wrote:
> > On Sat, Sep 25, 2010 at 12:17:07PM +0200, Janne Grunau wrote:
> > > On Sat, Sep 25, 2010 at 04:32:36AM +0200, Michael Niedermayer wrote:
> > > > On Fri, Sep 24, 2010 at 02:10:40PM +0200, Janne Grunau wrote:
> > > > 
> > > > >  ffmpeg.c |    4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > 4e6c7aa083bcaa3a70f16436b9b2084781af4bcc  video_enc_earlier_set_context_opts.diff
> > > > > commit 7240aadf429855433e641843b85198cfd5981a95
> > > > > Author: Janne Grunau <janne at grunau.be>
> > > > > Date:   Fri Sep 24 14:01:37 2010 +0200
> > > > > 
> > > > >     set video codec context options earlier to allow use of experimental video encoders
> > > > 
> > > > ok but this patch has some potential to conflict with future per codec
> > > > options and defaults
> > > 
> > > an alternative would be using avcodec_opts[AVMEDIA_TYPE_*]->strict_std_compliance
> > > directly. I've moved the set_context_opts call since it is that way for
> > > subtitle and audio codecs.
> > 
> > like attached
> 
> iam fine with either, it doesnt really matter currently how its done

Applied the second patch since it's more robust.

Janne