[FFmpeg-devel] [PATCH] Broken metadata conversion for ogg

[Patrice Bensoussan]

Hi,

It seems that the metadata conversion for ogg files has been broken recently. It seems to be caused by a change in oggparsevorbis.c when calling av_metadata_set2(). The patch below to revert the change seems to be fixing the issue, but not sure it's the right way to fix the problem... I assume m variable should be pointing to metadata too?

Patrice

Index: libavformat/oggparsevorbis.c
===================================================================
--- libavformat/oggparsevorbis.c	(revision 25249)
+++ libavformat/oggparsevorbis.c	(working copy)
@@ -125,7 +125,7 @@
             ct[vl] = 0;
 
             if (!ogm_chapter(as, tt, ct))
-                av_metadata_set2(m, tt, ct,
+                av_metadata_set2(&as->metadata, tt, ct,
                                    AV_METADATA_DONT_STRDUP_KEY |
                                    AV_METADATA_DONT_STRDUP_VAL);