[FFmpeg-devel] [PATCH]Plausibility check for TrueHD channel_layout

[Michael Niedermayer]

On Thu, Mar 31, 2011 at 10:32:13PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > +            if (av_popcount(avctx->channel_layout) != avctx->channels) {
> > > +                avctx->channel_layout = 0;
> > > +                av_log_ask_for_sample(avctx, "Unknown channel layout.");
> > > +            }
> > >          }
> > 
> > i think this shoulds be a if() level further outside
> 
> The condition can only be true for TrueHD streams, or do I miss something?

If the other code is never changed, yes
i had not noticed that so IMHO either placement is ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110401/cc92e87b/attachment.asc>