[FFmpeg-devel] [PATCH] ffmpeg: make 'bits_per_raw_sample' option more useful

[Michael Niedermayer]

On Sat, Apr 02, 2011 at 07:13:25PM +1100, Peter Ross wrote:
> Currently bits_per_raw_sample is exposes as an AVCodecContext option.
> The option is not very useful, because ffmpeg 1) overwrites it with
> a value from the upstream codec, or 2) it resets the value whenever
> the video is resampled.
> 
> This patch moves the bits_per_raw sample option into FFmpeg, and
> caches like is done for the pix_fmt option.
>
> Example usage:
> ffmpeg v210.avi -pix_fmt rgb48 -bits_per_raw_sample 10 out%d.dpx

[...]
> diff --git a/libavcodec/options.c b/libavcodec/options.c
> index 47854d9..84ad9b5 100644
> --- a/libavcodec/options.c
> +++ b/libavcodec/options.c
> @@ -404,7 +404,6 @@ static const AVOption options[]={
>  {"drc_scale", "percentage of dynamic range compression to apply", OFFSET(drc_scale), FF_OPT_TYPE_FLOAT, 1.0, 0.0, 1.0, A|D},
>  {"reservoir", "use bit reservoir", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_BIT_RESERVOIR, INT_MIN, INT_MAX, A|E, "flags2"},
>  {"mbtree", "use macroblock tree ratecontrol (x264 only)", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_MBTREE, INT_MIN, INT_MAX, V|E, "flags2"},
> -{"bits_per_raw_sample", NULL, OFFSET(bits_per_raw_sample), FF_OPT_TYPE_INT, DEFAULT, INT_MIN, INT_MAX},
>  {"channel_layout", NULL, OFFSET(channel_layout), FF_OPT_TYPE_INT64, DEFAULT, 0, INT64_MAX, A|E|D, "channel_layout"},
>  {"request_channel_layout", NULL, OFFSET(request_channel_layout), FF_OPT_TYPE_INT64, DEFAULT, 0, INT64_MAX, A|D, "request_channel_layout"},
>  {"rc_max_vbv_use", NULL, OFFSET(rc_max_available_vbv_use), FF_OPT_TYPE_FLOAT, 1.0/3, 0.0, FLT_MAX, V|E},

this should stay to allow accessing the field in a way that doesnt
depend on the structure layout



-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110402/8a14546e/attachment.asc>