[FFmpeg-devel] [PATCH 1/2] h264_parser: Fix behaviour when PARSER_FLAG_COMPLETE_FRAMES is set.

[Michael Niedermayer]

On Sun, Apr 03, 2011 at 09:22:11AM -0700, Philip Langdale wrote:
> On Tue, 29 Mar 2011 11:18:03 -0700
> Philip Langdale <philipl at overt.org> wrote:
> 
> >  On Tue, 29 Mar 2011 20:14:13 +0200, Reimar Döffinger 
> >  <Reimar.Doeffinger at gmx.de> wrote:
> > > On Mon, Mar 28, 2011 at 09:44:48PM -0700, Philip Langdale wrote:
> > >> @@ -282,10 +283,10 @@ static int h264_parse(AVCodecParserContext
> > >> *s, s->dts_ref_dts_delta = INT_MIN;
> > >>              s->pts_dts_delta     = INT_MIN;
> > >>          }
> > >> +
> > >>          if (s->flags & PARSER_FLAG_ONCE) {
> > >>              s->flags &= PARSER_FLAG_COMPLETE_FRAMES;
> > >>          }
> > >
> > > I think Michael really needs to comment on this, it changes
> > > PARSER_FLAG_ONCE in strange ways - not sure whether for better
> > > or worse.
> > 
> >  Well, it was certainly wrong before, but I have no idea if it's more
> >  or less wrong now.
> 
> Michael,
> 
> Can you comment on this one?

the patch should be ok if its tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110403/a54a431d/attachment.asc>