[FFmpeg-devel] [PATCH] add avcodec_get_subtitle_defaults() to initialize AVSubtitle struct

[Reimar Döffinger]

On Wed, Apr 06, 2011 at 02:31:38AM +0200, Michael Niedermayer wrote:
> On Wed, Apr 06, 2011 at 12:30:23AM +0200, Aurelien Jacobs wrote:
> > On Tue, Apr 05, 2011 at 06:26:22PM +0200, Reimar Döffinger wrote:
> > > On Tue, Apr 05, 2011 at 10:04:33AM +0200, Aurelien Jacobs wrote:
> > > > Call this new function before decode() to replace the custom and
> > > > inconsistant initialization in various decoders.
> > > > This function is equivalent to avcodec_get_frame_defaults() for AVFrame.
> > > 
> > > Any real reason to make it public?
> > 
> > Not really. I just did it the same way as avcodec_get_frame_defaults().
> > 
> > > We don't have much experience with subtitles yet, so I'd prefer if
> > > it wasn't public - who knows what kind of issues we might detect
> > > with it.
> > 
> > Agree. We can make it public when someone need it.
> > New patch attached with avcodec_get_subtitle_defaults() as a static
> > function.
> > 
> > Aurel
> >  ass.c       |    5 -----
> >  ass.h       |    7 -------
> >  assdec.c    |    2 --
> >  dvbsubdec.c |    3 ---
> >  dvdsubdec.c |    1 -
> >  pgssubdec.c |    1 -
> >  srtdec.c    |    2 --
> >  utils.c     |    7 +++++++
> >  xsubdec.c   |    2 --
> >  9 files changed, 7 insertions(+), 23 deletions(-)
> > 7585cd15b07fc9b0db143814855b3e684a7dd910  0001-add-avcodec_get_subtitle_defaults-to-initialize-AVSu.patch
> > From 383f5868f65424b4c08380a18a2e1b6b4ac1b33d Mon Sep 17 00:00:00 2001
> > From: Aurelien Jacobs <aurel at gnuage.org>
> > Date: Tue, 5 Apr 2011 09:04:48 +0200
> > Subject: [PATCH] add avcodec_get_subtitle_defaults() to initialize AVSubtitle struct
> 
> LGTM

Agreed.