[FFmpeg-devel] [PATCH] allows vf_drawtext to draw some filter context and environment variables

[Michael Niedermayer]

On Fri, Apr 08, 2011 at 11:49:51AM +0200, Jean First wrote:
> 
> Signed-off-by: Jean First <jeanfirst at gmail.com>
> ---
>  libavfilter/vf_drawtext.c |  132 ++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 131 insertions(+), 1 deletions(-)

This is missing documentation and contains trailing whitespace which
we cant push in the repo

[...]
> +                for ( ; *format; ++format) {
> +                    switch (*format) {                    
> +                    case '\0':
> +                        envfound = 0;
> +                        --format;
> +                        break;
> +                    case '#':
> +                    case ' ':
> +                        envfound = 0;
> +                        break;
> +                    default:
> +                        *penvkey++ = *format;

stack based buffer overflow
please review your code for similar issues before resubmitting


> +                        break;
> +                    }
> +                    if(!envfound)
> +                        break;
> +                }


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110409/d32d9a80/attachment.asc>