[FFmpeg-devel] [PATCH] Per-frame metadata

[Stefano Sabatini]

On date Tuesday 2011-04-12 19:01:08 +0200, Nicolas George encoded:
> Le tridi 23 germinal, an CCXIX, Stefano Sabatini a écrit :
> > Nit: multiply
> 
> Fixed locally.
> 
> > -1 -> AVERROR(EINVAL)
> 
> That require mem.h to include error.h, and this is the only conceivable
> error for av_size_mult, so I am mildly in favor of keeping -1. But if you
> insist on AVERROR(EINVAL) I will change.

In many cases we propagate the error code, not having to remap it is a
bonus.

> > Would it make sense to move metadata to libavutil rather than to
> > libavcodec?
> > 
> > For example you may need to display metadata from a lavfi filter.
> 
> libavutil was my first choice, as it has absorbed libavcore; but Michael
> seemed to prefer libavcodec.
> 
> If you think this is better in libavutil I will make the change.

My argument is that metadata is not codec-specific, so I consider
libavutil a better place (and at least per-frame metadata filtering
looks senseful, even if I can't imagine other uses outside libavcodec
at the moment).
-- 
FFmpeg = Formidable and Frightening Merciless Portable Explosive Guru