[FFmpeg-devel] [PATCH] Per-frame metadata

[Alexander Strasser]

Hi

Nicolas George wrote:
> Le tridi 23 germinal, an CCXIX, Stefano Sabatini a écrit :
> > Nit: multiply
> 
> Fixed locally.
> 
> > -1 -> AVERROR(EINVAL)
> 
> That require mem.h to include error.h, and this is the only conceivable
> error for av_size_mult, so I am mildly in favor of keeping -1. But if you
> insist on AVERROR(EINVAL) I will change.
> 
> > Would it make sense to move metadata to libavutil rather than to
> > libavcodec?
> > 
> > For example you may need to display metadata from a lavfi filter.
> 
> libavutil was my first choice, as it has absorbed libavcore; but Michael
> seemed to prefer libavcodec.
> 
> If you think this is better in libavutil I will make the change.

  Just for the record:

  I still dislike the merge of libavcore into libavutil and I dislike
adding more stuff on top of that, too.

  There should be better solutions like making lavfi purposefully
depend on lavc or something I didn't yet think of. I know this has
its drawbacks as well, but maybe something can be done about it.

  Alexander