[FFmpeg-devel] [PATCH 1/2] h264_parser: Fix behaviour when PARSER_FLAG_COMPLETE_FRAMES is set.

[Philip Langdale]

On Mon, 4 Apr 2011 22:08:07 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> On Mon, Apr 04, 2011 at 09:47:54AM -0700, Philip Langdale wrote:
> > On Sun, 3 Apr 2011 23:15:33 +0200, Michael Niedermayer  
> > <michaelni at gmx.at> wrote:
> >> On Sun, Apr 03, 2011 at 09:22:11AM -0700, Philip Langdale wrote:
> >>>
> >>> Can you comment on this one?
> >>
> >> the patch should be ok if its tested
> >>
> >
> > I tested it with my other pending patches, and it worked as I
> > expected. Certainly, the behaviour can't be any worse than it was
> > before :-)
> >
> > Can I consider this an ACK and push it?
> 
> ack

Further testing at my end has shown my fix to be incomplete, at the
very least. While the old code is unambiguously wrong, my fix isn't
enough to make it work correctly. I actually ended up checking in
my CrystalHD code without setting the COMPLETE_FRAMES flag because
of this. It's going to require more investigation.

--phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110413/637e8e2f/attachment.asc>