[FFmpeg-devel] [PATCH] CrystalHD: Use lowres option to expose hardware scaling.

[Reimar Döffinger]

On Sat, Apr 16, 2011 at 03:43:03PM -0700, Philip Langdale wrote:
> The CrystalHD hardware can do scaling, which is particularly
> desirable when dealing with some high resolution clips that take
> so long to decode and copy out that they end up playing back
> slower than realtime. By using scaling, we can make the output
> frames smaller and reduce the copy out time.
> 
> The official lowres semantics are that the resolution should be
> divided by 2^n but this would prevent scaling to resolutions
> higher than 960x540 for 1920x1080 content. So, I am abusing the
> semantics by assigning specific resolutions to each value.

I don't think it's a good idea to misuse it in such a way, when it's
a completely new API you could just use a new option instead.
Your solution can end up with lowres increasing the resolution, that
especially might cause issues for applications that expect lowres
to behave in the usual way.
Btw. there's a few tabs in there.