[FFmpeg-devel] [PATCH] Lost VBR header

[Peter Belkner]

On 17.04.2011 16:07, Reimar Döffinger wrote:
> On Sun, Apr 17, 2011 at 03:49:26PM +0200, Peter Belkner wrote:
>    
>> On 17.04.2011 14:32, Reimar Döffinger wrote:
>>      
>>> you end up with a VBR header in the middle.
>>>        
>> This can easily fixed at playback/decoding time by applying the test
>> for VBR headers proposed for the decoder not only to the first frame
>> but to each. I think the test in the decoder is a good idea on its
>> own, independent on how the MP3 demuxer deals with it, because the
>> MP3 stream may not come from an MP3 format.
>>
>> I would prefer to have the test at each frame.
>>      
> Yes, I was thinking to suggest this.
> I was/am just a bit unsure if the test is good enough or might have a
> too high false-positive rate.
> Naive calculation says the false positive rate would be about 3 in 4 billion
> which should be fine but I haven't thought much about if the naive
> approach is correct.
>    


For the moment I think it's best to leave it as it is and hear some 
other opinions.

Peter