[FFmpeg-devel] [PATCH] Per-frame metadata

[Nicolas George]

Le quartidi 4 floréal, an CCXIX, Michael Niedermayer a écrit :
> what does the _f stand for?

Something like _or_free. I thought that a name av_realloc_or_free would have
been too verbose, but I do not mind if people prefer it that way.

> > +    if ((a | b) >= ((size_t)1 << (sizeof(size_t) * 4)) && a && t / a != b)
> > +        return -1;
> LGTM

I have a version with AVERROR(EINVAL) instead of -1, as requested by
Stefano, in my working tree; it requires an additional #include. I'll rebase
and submit it soon.

> That looks like it will cause a leak in applications using their own
> release_buffer()

Indeed, unless they use avcodec_default_release_buffer underhanded or free
it themselves.

I see no obvious solution to avoid that, but I'll think about it some more.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110423/93fd505e/attachment.asc>