[FFmpeg-devel] [RFC][PATCH] Move picture type definitions from libavcodec to libavutil

[Stefano Sabatini]

On date Sunday 2011-04-24 04:00:20 +0200, Michael Niedermayer encoded:
> On Sat, Apr 23, 2011 at 08:47:01PM +0200, Stefano Sabatini wrote:
> > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> > Cc: 
> > Bcc: 
> > Subject: Re: [FFmpeg-devel] [RFC][PATCH] Move picture type definitions from
> > 	libavcodec to libavutil
> > Reply-To: 
> > In-Reply-To: <20110423175414.GB19660 at kiste2>
> > 
> > On date Saturday 2011-04-23 19:54:14 +0200, Michael Niedermayer encoded:
> > > On Sat, Apr 23, 2011 at 05:28:30PM +0200, Stefano Sabatini wrote:
> > [...]
> > > > @@ -3863,7 +3863,9 @@ void avcodec_default_free_buffers(AVCodecContext *s);
> > > >   *
> > > >   * @param[in] pict_type the picture type
> > > >   * @return A single character representing the picture type.
> > > > + * @deprecated use av_get_picture_type_char() instead
> > > >   */
> > > > +attribute_deprecated
> > > >  char av_get_pict_type_char(int pict_type);
> > > 
> > > this function looks fine to me, i see no need to change it
> > 
> > But, it is defined in libavcodec, and I would like to avoid
> > breakages as the function is moved from libavcodec to libavutil.
> > 
> > The new function in libavutil has a different name
> > (av_get_pictURE_type_char), which is also sligthly more consistent
> > with the enum name.
> 

> IMHO
> every rename causes work for the developers of user applications. who
> must adapat their code. moving the fuinction without changing its name
> means less work for them.

This is not a very common function, the old function is kept, the new
name is more consistent with the corresponding enum, and keeping the
old function avoids potential problems due to the move.

That's why I want to keep the current patch (I'll send an update in a
moment).
-- 
FFmpeg = Friendly & Faithless Minimalistic Power Erudite Game