[FFmpeg-devel] [libav-devel] [RFC][PATCH] Move picture type definitions from libavcodec to libavutil

[Michael Niedermayer]

On Sun, Apr 24, 2011 at 06:43:41PM +0200, Stefano Sabatini wrote:
> On date Saturday 2011-04-23 17:28:30 +0200, Stefano Sabatini encoded:
> > On date Saturday 2011-04-23 13:54:52 +0200, Nicolas George encoded:
> > > Le quartidi 4 floréal, an CCXIX, Stefano Sabatini a écrit :
> > > > This breaks ABI as it redefines the previous values (since the first
> > > > symbol will have a value of 0 rather than 1, consistent with enum
> > > > definitions and allows the AV_*_NB trick).
> > > 
> > > Couldn't you add some sort of AV_PICTURE_TYPE_UNSPEC =0 to preserve the
> > > values?
> > 
> > Rethinking about it, I dropped the redefinition (which were causing
> > regressions, since the literal pict_type values are used in MPEG
> > video) and the *_NB trick.
> > 
> > No ABI breaks anymore.
> 
> Patch updated with removal guards added.
> -- 
> FFmpeg = Freak & Forgiving Most Ponderous Esoteric Guru

>  libavcodec/avcodec.h   |   24 +++++++++++++++---------
>  libavcodec/utils.c     |   13 +++----------
>  libavcodec/version.h   |    3 +++
>  libavfilter/avfilter.h |    2 +-
>  libavutil/avutil.h     |   19 +++++++++++++++++++
>  libavutil/utils.c      |   14 ++++++++++++++
>  6 files changed, 55 insertions(+), 20 deletions(-)
> 82a00b77571a0f086780c50e83f65bc9b76e5d66  0001-lavc-deprecate-FF_-_TYPE-macros-in-favor-of-AV_PICTU.patch
> From 89fb13bf6edc5fbcf149e8855e89605db84719a6 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sat, 23 Apr 2011 13:38:50 +0200
> Subject: [PATCH] lavc: deprecate FF_*_TYPE macros in favor of AV_PICTURE_TYPE_* enums

if you prefer it this way then iam not against

    [...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110424/4b9c7f45/attachment.asc>