[FFmpeg-devel] [PATCH] smacker: remove unnecessary call to avctx->release_buffer in decode_frame()

Stefano Sabatini stefano.sabatini-lala at poste.it
Tue Apr 26 11:37:36 CEST 2011


The release_buffer was cleaning the provided frame, thus causing the
successive call to avctx->reget_buffer() to allocate a new frame.  In
case the returned frame was not the same one previously returned but a
new one with different data, it resulted in artifacts.

Fix trac issue #87.

Signed-off-by: Stefano Sabatini <stefano.sabatini-lala at poste.it>
---
 libavcodec/smacker.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
index e3f00b8..e6c3460 100644
--- a/libavcodec/smacker.c
+++ b/libavcodec/smacker.c
@@ -360,8 +360,6 @@ static int decode_frame(AVCodecContext *avctx, void *data, int *data_size, AVPac
 
     if(buf_size <= 769)
         return 0;
-    if(smk->pic.data[0])
-            avctx->release_buffer(avctx, &smk->pic);
 
     smk->pic.reference = 1;
     smk->pic.buffer_hints = FF_BUFFER_HINTS_VALID | FF_BUFFER_HINTS_PRESERVE | FF_BUFFER_HINTS_REUSABLE;
-- 
1.7.2.3



More information about the ffmpeg-devel mailing list